Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trycycler cluster #5670

Merged
merged 5 commits into from
May 25, 2024
Merged

Trycycler cluster #5670

merged 5 commits into from
May 25, 2024

Conversation

watsonar
Copy link
Contributor

PR checklist

Contributes second trycycler command (trycycler cluster) for #829
Still need to add trycycler reconcile, msa, partition, and consensus

Includes nf-tests, and a stub, and an nf-test for the stub.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@watsonar watsonar requested a review from a team as a code owner May 22, 2024 19:16
@watsonar watsonar requested review from CarsonJM and removed request for a team May 22, 2024 19:16
@SPPearce SPPearce added this pull request to the merge queue May 25, 2024
Merged via the queue into nf-core:master with commit e788348 May 25, 2024
16 checks passed
@watsonar watsonar deleted the trycycler-cluster branch May 28, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants